[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param#269741
Merged
Conversation
mykolaharmash
added
release_note:skip
…m search URL param
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.3, 9.4 |
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 20, 2026
… search URL param (#269741) (#270124) # Backport This will backport the following commits from `main` to `9.4`: - [[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param (#269741)](#269741) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2026-05-20T09:54:06Z","message":"[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param (#269741)\n\nCloses https://github.com/elastic/observability-error-backlog/issues/808\n\nAdds guard for invalid syntax inside the `search` URL param. The app\ndoesn't write an invalid search query into the URL when user enters it\nin the field, but it's still possible to modify the URL directly, which\nwill crash the app when trying to read the parameter.","sha":"d1f70d8e53aacd45015c4239358a18d4388b5f6b","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v9.5.0"],"title":"[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param","number":269741,"url":"https://github.com/elastic/kibana/pull/269741","mergeCommit":{"message":"[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param (#269741)\n\nCloses https://github.com/elastic/observability-error-backlog/issues/808\n\nAdds guard for invalid syntax inside the `search` URL param. The app\ndoesn't write an invalid search query into the URL when user enters it\nin the field, but it's still possible to modify the URL directly, which\nwill crash the app when trying to read the parameter.","sha":"d1f70d8e53aacd45015c4239358a18d4388b5f6b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/269741","number":269741,"mergeCommit":{"message":"[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param (#269741)\n\nCloses https://github.com/elastic/observability-error-backlog/issues/808\n\nAdds guard for invalid syntax inside the `search` URL param. The app\ndoesn't write an invalid search query into the URL when user enters it\nin the field, but it's still possible to modify the URL directly, which\nwill crash the app when trying to read the parameter.","sha":"d1f70d8e53aacd45015c4239358a18d4388b5f6b"}}]}] BACKPORT--> Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
May 20, 2026
… search URL param (#269741) (#270123) # Backport This will backport the following commits from `main` to `9.3`: - [[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param (#269741)](#269741) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2026-05-20T09:54:06Z","message":"[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param (#269741)\n\nCloses https://github.com/elastic/observability-error-backlog/issues/808\n\nAdds guard for invalid syntax inside the `search` URL param. The app\ndoesn't write an invalid search query into the URL when user enters it\nin the field, but it's still possible to modify the URL directly, which\nwill crash the app when trying to read the parameter.","sha":"d1f70d8e53aacd45015c4239358a18d4388b5f6b","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v9.5.0"],"title":"[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param","number":269741,"url":"https://github.com/elastic/kibana/pull/269741","mergeCommit":{"message":"[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param (#269741)\n\nCloses https://github.com/elastic/observability-error-backlog/issues/808\n\nAdds guard for invalid syntax inside the `search` URL param. The app\ndoesn't write an invalid search query into the URL when user enters it\nin the field, but it's still possible to modify the URL directly, which\nwill crash the app when trying to read the parameter.","sha":"d1f70d8e53aacd45015c4239358a18d4388b5f6b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/269741","number":269741,"mergeCommit":{"message":"[Obs Onboarding] Fix app crash when parsing invalid syntax from search URL param (#269741)\n\nCloses https://github.com/elastic/observability-error-backlog/issues/808\n\nAdds guard for invalid syntax inside the `search` URL param. The app\ndoesn't write an invalid search query into the URL when user enters it\nin the field, but it's still possible to modify the URL directly, which\nwill crash the app when trying to read the parameter.","sha":"d1f70d8e53aacd45015c4239358a18d4388b5f6b"}}]}] BACKPORT--> Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>
dennis-tismenko
pushed a commit
to dennis-tismenko/kibana
that referenced
this pull request
May 20, 2026
…h URL param (elastic#269741) Closes elastic/observability-error-backlog#808 Adds guard for invalid syntax inside the `search` URL param. The app doesn't write an invalid search query into the URL when user enters it in the field, but it's still possible to modify the URL directly, which will crash the app when trying to read the parameter.
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
May 22, 2026
…h URL param (elastic#269741) Closes elastic/observability-error-backlog#808 Adds guard for invalid syntax inside the `search` URL param. The app doesn't write an invalid search query into the URL when user enters it in the field, but it's still possible to modify the URL directly, which will crash the app when trying to read the parameter.
jcger
pushed a commit
that referenced
this pull request
May 26, 2026
…h URL param (#269741) Closes elastic/observability-error-backlog#808 Adds guard for invalid syntax inside the `search` URL param. The app doesn't write an invalid search query into the URL when user enters it in the field, but it's still possible to modify the URL directly, which will crash the app when trying to read the parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/observability-error-backlog/issues/808
Adds guard for invalid syntax inside the
searchURL param. The app doesn't write an invalid search query into the URL when user enters it in the field, but it's still possible to modify the URL directly, which will crash the app when trying to read the parameter.